Add WebhookTypes and EventForType methods

[evankanderson]

Fixes #2863

[gmlewis]

Could you please also add tests for requesting a nil event, an unknown event, and any other place where we pass in garbage to make sure it behaves properly in all cases?

[evankanderson]

I switched to a bit of judicious reflection for the struct copy and pre-computation for the rest of the mappings, and now this is a nicely negative total lines of code PR. 😁

[codecov]

Codecov Report

Merging #2865 (848850a) into master (0c10d67) will decrease coverage by 0.02%.
Report is 4 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2865      +/-   ##
==========================================
- Coverage   98.07%   98.05%   -0.02%     
==========================================
  Files         139      139              
  Lines       12357    12253     -104     
==========================================
- Hits        12119    12015     -104     
  Misses        162      162              
  Partials       76       76              

Files Changed	Coverage Δ
github/event.go	100.00% <100.00%> (ø)
github/messages.go	100.00% <100.00%> (ø)
github/repos_hooks_deliveries.go	92.45% <100.00%> (ø)

... and 2 files with indirect coverage changes

[gmlewis]

Thank you, @evankanderson !
A few more tweaks, please, then I think we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

[evankanderson]

Ready for another look / another reviewer, I think.

[evankanderson]

Do you want me to flatten my commits?

[gmlewis]

Do you want me to flatten my commits?

No need to flatten any commits, as we always "squash and merge" in this repo. Thank you, though.

[gmlewis]

@evankanderson - this looks great to me!
Thank you for your patience and your willingness to experiment with this one.
I think this looks super clean and will help with reducing not only the maintenance burden of this repo, but also make it much easier for contributors to add new event types as GitHub keeps cranking them out. 😁

LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

[gmlewis]

@googlebot - why have you been silent on this PR? What happened to your automated CLA checks?!?

[gmlewis]

Ah, is @googlebot dead and been replaced by @google-cla instead?

[gmlewis]

@google-ospo-team - can you please investigate why this PR was never checked by the @google-cla bot?
I can't move forward on this PR until it verifies the CLA is signed by all parties.
Thank you!

[gmlewis]

CLA has been cleared. Thank you, @google-ospo-team !

Now awaiting second LGTM+Approval from any other contributor to this repo before merging.

[gmlewis]

@Parker77 - do you have time for a code review, please?

[Parker77]

LGTM!

[gmlewis]

Thank you, @Parker77 !
Merging.