Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for organization, repository webhook configuration #2885

Merged
merged 3 commits into from
Aug 21, 2023
Merged

Add support for organization, repository webhook configuration #2885

merged 3 commits into from
Aug 21, 2023

Conversation

mnafees
Copy link
Contributor

@mnafees mnafees commented Aug 19, 2023

Closes #2884

This PR adds support for fetching and updating organization, repository webhook configuration

  • go generate
  • go test
  • go vet

@codecov
Copy link

codecov bot commented Aug 19, 2023 •
edited
Loading

Codecov Report

Merging #2885 (7aa8ad8) into master (7ceef94) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2885   +/-   ##
=======================================
  Coverage   98.06%   98.07%           
=======================================
  Files         140      142    +2     
  Lines       12293    12341   +48     
=======================================
+ Hits        12055    12103   +48     
  Misses        162      162           
  Partials       76       76
Files Changed Coverage Δ
github/orgs_hooks_configuration.go 100.00% <100.00%> (ø)
github/repos_hooks_configuration.go 100.00% <100.00%> (ø)

gmlewis
gmlewis requested changes Aug 19, 2023
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mnafees !
Just a couple tweaks, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

github/orgs_hooks_configuration.go Outdated Show resolved Hide resolved
github/orgs_hooks_configuration.go Outdated Show resolved Hide resolved
github/repos_hooks_configuration.go Outdated Show resolved Hide resolved
github/repos_hooks_configuration.go Outdated Show resolved Hide resolved
@mnafees mnafees requested a review from gmlewis August 20, 2023 08:41
gmlewis
gmlewis approved these changes Aug 20, 2023
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mnafees !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Aug 20, 2023
@gmlewis
Copy link
Collaborator

gmlewis commented Aug 21, 2023

Thank you, @gabriel-samfira !
Merging.

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Aug 21, 2023
@gmlewis gmlewis merged commit 505b7ea into google:master Aug 21, 2023
9 checks passed
@gmlewis gmlewis mentioned this pull request Sep 5, 2023
Merged
gmlewis pushed a commit to gmlewis/go-github that referenced this pull request Sep 19, 2023
@mnafees @gmlewis
Add support for organization, repository webhook configuration (googl…
224f6c8 
…e#2885)

Fixes: google#2884.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlewis gmlewis gmlewis approved these changes

@gabriel-samfira gabriel-samfira gabriel-samfira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for organization, repository webhook configuration
3 participants
@mnafees @gmlewis @gabriel-samfira