-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return json.Unmarshal error when importing issues deferred #2892
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2892 +/- ##
==========================================
+ Coverage 98.06% 98.10% +0.04%
==========================================
Files 140 142 +2
Lines 12269 12340 +71
==========================================
+ Hits 12031 12106 +75
+ Misses 162 159 -3
+ Partials 76 75 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @nikpivkin !
Could you please add a test case that demonstrates the problem?
In the past, I've found it really handy to demonstrate json.Unmarshal
errors by forcing the data to be something bogus for JSON like {]
.
@gmlewis Hi! Fixed! The initial fix was that the error did not return when the response status was 202. (nil returned) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @nikpivkin !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
Thank you, @gabriel-samfira ! |
The error was not returned when the 202 status was received during the issues import.