Escape package names to support names which include a slash

[bn4t]

Package names aren't escaped before being added to the url.
E.g. orgs/foo/packages/container/foo/bar instead of orgs/foo/packages/container/foo%2Fbar

This causes 404 errors for such packages.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (50d4db2) 97.91% compared to head (5a5a215) 97.91%.
Report is 3 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3002   +/-   ##
=======================================
  Coverage   97.91%   97.91%           
=======================================
  Files         150      150           
  Lines       12980    12980           
=======================================
  Hits        12710    12710           
  Misses        192      192           
  Partials       78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[gmlewis]

Thank you, @bn4t !

For each of the modified methods, could you please add a godoc comment (since this is a change of behavior) and also a unit test that demonstrates the new path escaping?

For example:

// Note that packageName is escaped for the URL path so that you don't need to.

[bn4t]

@gmlewis Would it be fine if I just changed the existing tests to use a package name with a slash or do you want me to write one/multiple new tests for this?

[gmlewis]

Thanks, @bn4t .
Please don't force-push as it makes it challenging for reviewers to see what changed since the last review. Also, we always squash-and-merge in this repo, so it doesn't matter how many pushes are in a PR - they will all end up as one commit when we merge.

[gmlewis]

@gmlewis Would it be fine if I just changed the existing tests to use a package name with a slash or do you want me to write one/multiple new tests for this?

I think it is totally fine to modify the existing tests. Thanks.

[gmlewis]

Please run step 4 of our CONTRIBUTING.md guide and push the results to this PR. That should fix the linter errors.
Thanks.

[bn4t]

@gmlewis Okay, pushed it. Thanks for handholding me through this, this really shouldn't have taken so long. My fault for not checking the contributing guidelines in detail.

[gmlewis]

@gmlewis Okay, pushed it. Thanks for handholding me through this, this really shouldn't have taken so long. My fault for not checking the contributing guidelines in detail.

No problem, we do have a lot of automation in this repo that is not immediately obvious.

[gmlewis]

Thank you, @bn4t !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

[valbeat]

LGTM!

[gmlewis]

Thank you, @valbeat !
Merging.