Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken CreateOrUpdateRepoCustomPropertyValues #3023

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

peter-aglen
Copy link
Contributor

Closes #3021.

Copy link

google-cla bot commented Dec 7, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gmlewis gmlewis added bug Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1e66201) 97.91% compared to head (4db1639) 97.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3023   +/-   ##
=======================================
  Coverage   97.91%   97.91%           
=======================================
  Files         150      150           
  Lines       12980    12980           
=======================================
  Hits        12710    12710           
  Misses        192      192           
  Partials       78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @peter-aglen !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Dec 7, 2023
Copy link
Contributor

@liaodaniel liaodaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Dec 8, 2023
@gmlewis
Copy link
Collaborator

gmlewis commented Dec 8, 2023

Thank you, @liaodaniel !
Merging.

@gmlewis gmlewis merged commit c135be9 into google:master Dec 8, 2023
7 checks passed
gmlewis pushed a commit to WillAbides/go-github that referenced this pull request Dec 18, 2023
gmlewis pushed a commit to o-sama/go-github that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in CreateOrUpdateRepoCustomPropertyValues?
3 participants