Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list repo org variables and secrets #3058

Merged

Conversation

tomfeigin
Copy link
Contributor

This wraps two repository API endpoints which are currently not available in the interface:

Copy link

google-cla bot commented Jan 25, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Wrap the 'organization-variables' endpoint for a repository to fetch
action variables.
Wrap the 'organization-secrets' endpoint for a repository to fetch
action secrets.
@tomfeigin tomfeigin force-pushed the add-list-repo-org-variables-and-secrets branch from ce9c9d4 to 22cf5a9 Compare January 25, 2024 10:12
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (20fc901) 97.71% compared to head (22cf5a9) 97.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3058   +/-   ##
=======================================
  Coverage   97.71%   97.71%           
=======================================
  Files         152      152           
  Lines       13326    13332    +6     
=======================================
+ Hits        13021    13027    +6     
  Misses        215      215           
  Partials       90       90           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @tomfeigin !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Jan 26, 2024
Copy link
Contributor

@fchimpan fchimpan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thanks @tomfeigin
LGTM🎉

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 27, 2024

Thank you, @fchimpan !
Merging.

@gmlewis gmlewis merged commit d26bcb8 into google:master Jan 27, 2024
7 checks passed
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants