-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for merge queue ruleset JSON unmarshaling #3131
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Matthew-Reidy !
Just a couple minor tweaks, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3131 +/- ##
==========================================
- Coverage 97.72% 92.88% -4.84%
==========================================
Files 153 170 +17
Lines 13390 11426 -1964
==========================================
- Hits 13085 10613 -2472
- Misses 215 723 +508
Partials 90 90 ☔ View full report in Codecov by Sentry. |
Sure thing. I'll fix those items shortly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Matthew-Reidy !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
Just a minor comment to update but looks good otherwise |
Co-authored-by: Daniel Liao <[email protected]>
changes to that comment have been made |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you, @liaodaniel ! |
Fixes: #3098.
Added support for respository ruleset merge_queue in JSON unmarshalling code with accompanying tests