-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enums for webhook payloads action field #3136
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3136 +/- ##
==========================================
- Coverage 97.72% 92.88% -4.84%
==========================================
Files 153 170 +17
Lines 13390 11426 -1964
==========================================
- Hits 13085 10613 -2472
- Misses 215 723 +508
Partials 90 90 ☔ View full report in Codecov by Sentry. |
Ah! Now I understand better the scope of this breaking API change. I would like @willnorris to weigh in on this PR to get his thoughts on the value of this change vs the breaking nature of it (and therefore the impact on developers) before we proceed further. |
Makes sense! |
@gmlewis @willnorris any update on the PR? |
this can be done progressively as well if you prefer and do it one event at a time (or in batches) |
If we're going to proceed, then I think one huge breaking change like this is probably better than a bunch of smaller changes. But I would still like to hear what @willnorris thinks about changing all the |
Relevant Issue: #3127