-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CommitID, InReplyTo, and SubjectType to DraftReviewComment #3169
Conversation
Position *int `json:"position,omitempty"` | ||
Body *string `json:"body,omitempty"` | ||
CommitID *string `json:"commit_id,omitempty"` | ||
InReplyTo *int64 `json:"in_reply_to,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On this page: https://docs.github.com/en/rest/pulls/reviews?apiVersion=2022-11-28#list-comments-for-a-pull-request-review--code-samples
I see in_reply_to_id
but I'm not finding id_reply_to
anywhere on the page.
Where are you finding that field?
Also, I'm not finding subject_type
anywhere on that page. Where is that field coming from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see them now on this page :https://docs.github.com/en/rest/pulls/comments?apiVersion=2022-11-28#create-a-review-comment-for-a-pull-request
Sorry for the confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @matt-simons !
LGTM.
Merging.
google#3169)" This reverts commit 06c9709.
closes #3168
Made InReplyTo an int64 following the established type in https://pkg.go.dev/github.com/google/go-github/v62/github#PullRequestComment but happy to change if that or anything else is incorrect.