Add support for filepath repository rules #3233
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3233 +/- ##
==========================================
- Coverage 97.72% 92.95% -4.78%
==========================================
Files 153 171 +18
Lines 13390 11646 -1744
==========================================
- Hits 13085 10825 -2260
- Misses 215 727 +512
- Partials 90 94 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Thank you, @grahamhar!
Just a couple minor tweaks, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.
Co-authored-by: Glenn Lewis <[email protected]>
There was a problem hiding this comment.
Thank you, @grahamhar!
In the future, please don't force-push in this repo as it makes code reviews more challenging. For this PR it was no big deal, but when the PRs get bigger, it becomes an issue. We always squash-and-merge PRs anyway, so there is no need for a force-push. Thanks.
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
|
Thank you, @tomfeigin ! |
|
@gmlewis sorry to trouble you but when is the next release due? |
No troubles. It looks like we are due for a roughly-monthly release so I will try to get this done by tonight (EDT). |
Release completed: https://github.com/google/go-github/releases/tag/v64.0.0 |
Fixes: #3231.
This is an attempt to add support for file_path_restriction in repository rules. It will implement #3231