Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Fix meta service domains schema structure #3249

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

lrstanley
Copy link
Contributor

@lrstanley lrstanley commented Aug 22, 2024

Fixes: #3248.

BREAKING CHANGE: APIMeta.Domains changed from map to struct.

This should at least be a tiny bit less prone to breaking, as it only accounts for existing schema with that API, and future additions should silently be ignored (unless GitHub breaks the contract, which they didn't really do in this scenario).

@lrstanley lrstanley marked this pull request as draft August 22, 2024 15:20
@gmlewis gmlewis changed the title breaking: fix meta service domains schema structure feat!: Fix meta service domains schema structure Aug 22, 2024
@gmlewis gmlewis added the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label Aug 22, 2024
@lrstanley lrstanley marked this pull request as ready for review August 22, 2024 15:21
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Aug 22, 2024
@gmlewis
Copy link
Collaborator

gmlewis commented Aug 22, 2024

(No need to force-push PRs in this repo, @lrstanley - as we always squash and merge.)

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.95%. Comparing base (2b8c7fa) to head (af7c7fc).
Report is 103 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3249      +/-   ##
==========================================
- Coverage   97.72%   92.95%   -4.78%     
==========================================
  Files         153      171      +18     
  Lines       13390    11646    -1744     
==========================================
- Hits        13085    10825    -2260     
- Misses        215      727     +512     
- Partials       90       94       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @lrstanley !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

Copy link
Contributor

@tomfeigin tomfeigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis
Copy link
Collaborator

gmlewis commented Aug 26, 2024

Thank you, @tomfeigin !
Merging.

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Aug 26, 2024
@gmlewis gmlewis merged commit da7d014 into google:master Aug 26, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).
Projects
None yet
3 participants