-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Fix meta service domains schema structure #3249
Conversation
9b627d3
to
90bf4dc
Compare
- closes google#3248 Signed-off-by: Liam Stanley <[email protected]>
90bf4dc
to
af7c7fc
Compare
(No need to force-push PRs in this repo, @lrstanley - as we always squash and merge.) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3249 +/- ##
==========================================
- Coverage 97.72% 92.95% -4.78%
==========================================
Files 153 171 +18
Lines 13390 11646 -1744
==========================================
- Hits 13085 10825 -2260
- Misses 215 727 +512
- Partials 90 94 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @lrstanley !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you, @tomfeigin ! |
Fixes: #3248.
BREAKING CHANGE:
APIMeta.Domains
changed frommap
tostruct
.This should at least be a tiny bit less prone to breaking, as it only accounts for existing schema with that API, and future additions should silently be ignored (unless GitHub breaks the contract, which they didn't really do in this scenario).
MetaService.Get
fails because the schema of the JSON in the API response is different from the expected inAPIMeta.Domains
type #3248