Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove deprecated build constraints #3306

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Oct 5, 2024

This PR removes outdated // +build comments. The "Build constraints" says:

Go versions 1.16 and earlier used a different syntax for build constraints, with a "// +build" prefix. The gofmt command will add an equivalent //go:build constraint when encountering the older syntax.

NOTE: This change breaks compatibility with Go 1.16. The library will compile only with Go 1.17+.

@gmlewis
Copy link
Collaborator

gmlewis commented Oct 5, 2024

Remember our discussion about "requiring" a minimum version of Go?
This is one of those things that allows this repo to require a minimum version of Go 1.16.
Once we make this change, Go 1.16 will no longer work with this repo.

Granted, it would seem weird to me that anyone might still want to use Go 1.16.

I'm totally fine to "move the bar" with this PR. However, we should probably leave this open for a week or so in order to allow anyone who cares deeply about this to respond.

Also, I'm thinking would should reinstate our attempt to keep track of the minimum Go version requirement in the README (and also attempt to keep it better up-to-date, which is my fault).

Copy link

codecov bot commented Oct 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.29%. Comparing base (2b8c7fa) to head (a7e5792).
Report is 152 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3306      +/-   ##
==========================================
- Coverage   97.72%   93.29%   -4.43%     
==========================================
  Files         153      171      +18     
  Lines       13390    11729    -1661     
==========================================
- Hits        13085    10943    -2142     
- Misses        215      692     +477     
- Partials       90       94       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @alexandear !
LGTM.

Allowing this PR to sit for one week until October 12, 2024 before merging in order to let other users of this repo to object to this change with their reasoning for retaining support for Go 1.16.

@gmlewis
Copy link
Collaborator

gmlewis commented Oct 11, 2024

NOTE that if there are no objections to this PR breaking support for Go 1.16, we will proceed with the merge tomorrow.

@gmlewis
Copy link
Collaborator

gmlewis commented Oct 11, 2024

@alexandear - would you mind adding to this PR a note in README.md that specifies that Go 1.17 is the minimum required version of the Go toolchain to use with this repo, please?

@alexandear
Copy link
Contributor Author

@gmlewis added info about Go 1.17+, please check

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gmlewis added info about Go 1.17+, please check

Beautiful, thank you, @alexandear !
Merging.

@gmlewis gmlewis merged commit 8fbbcf8 into google:master Oct 14, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants