-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove deprecated build constraints #3306
chore: Remove deprecated build constraints #3306
Conversation
Remember our discussion about "requiring" a minimum version of Go? Granted, it would seem weird to me that anyone might still want to use Go 1.16. I'm totally fine to "move the bar" with this PR. However, we should probably leave this open for a week or so in order to allow anyone who cares deeply about this to respond. Also, I'm thinking would should reinstate our attempt to keep track of the minimum Go version requirement in the README (and also attempt to keep it better up-to-date, which is my fault). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3306 +/- ##
==========================================
- Coverage 97.72% 93.29% -4.43%
==========================================
Files 153 171 +18
Lines 13390 11729 -1661
==========================================
- Hits 13085 10943 -2142
- Misses 215 692 +477
- Partials 90 94 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @alexandear !
LGTM.
Allowing this PR to sit for one week until October 12, 2024 before merging in order to let other users of this repo to object to this change with their reasoning for retaining support for Go 1.16.
NOTE that if there are no objections to this PR breaking support for Go 1.16, we will proceed with the merge tomorrow. |
@alexandear - would you mind adding to this PR a note in README.md that specifies that Go 1.17 is the minimum required version of the Go toolchain to use with this repo, please? |
@gmlewis added info about Go 1.17+, please check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gmlewis added info about Go 1.17+, please check
Beautiful, thank you, @alexandear !
Merging.
This PR removes outdated
// +build
comments. The "Build constraints" says:NOTE: This change breaks compatibility with Go 1.16. The library will compile only with Go 1.17+.