Implement Parse and Translate methods that return readers #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always reading the response body into memory results in unnecessary and undesired allocations, especially when sending large documents to Tika for parsing. The call method, which is called for all API requests, doesn't copy the response anymore. Instead, callString copies it for the methods that return strings and callUnmarshal does its own buffering using the JSON decoder. This commit also creates a new method, ParseReader, which allows users of the client to omit copying the response, but instead receive its reader directly, which they are responsible to close.
As with ParseReader, a TranslateReader is provided for the same reasons.
|
Shouldn't changes be tagged? The last tag is from 2019. |
|
I tagged a new release ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #33