-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[launcher] Add configurable /dev/shm size and tmpfs mount option #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/gcbrun |
alexmwu
force-pushed
the
tmpfs
branch
2 times, most recently
from
May 10, 2024 22:45
15af756
to
d11dd9c
Compare
/gcbrun |
alexmwu
force-pushed
the
tmpfs
branch
2 times, most recently
from
May 10, 2024 23:01
18e7333
to
f60e1c8
Compare
/gcbrun |
alexmwu
force-pushed
the
tmpfs
branch
2 times, most recently
from
June 21, 2024 23:11
1d38d36
to
9609cf4
Compare
alexmwu
changed the title
Add configurable /dev/shm size for CS workloads
[launcher] Add configurable /dev/shm size and tmpfs mount option
Jun 22, 2024
/gcbrun |
/gcbrun |
/gcbrun |
/gcbrun |
/gcbrun |
alexmwu
force-pushed
the
tmpfs
branch
2 times, most recently
from
June 26, 2024 18:50
29195f6
to
6244399
Compare
/gcbrun |
/gcbrun |
/gcbrun |
/gcbrun |
1 similar comment
/gcbrun |
/gcbrun |
jkl73
reviewed
Jul 3, 2024
launcher/spec/launch_policy.go
Outdated
Comment on lines
108
to
114
// default is debug only for memoryMonitoring | ||
if v, ok := imageLabels[memoryMonitoring]; ok { | ||
launchPolicy.AllowedMemoryMonitoring, err = toPolicy(memoryMonitoring, v) | ||
if err != nil { | ||
return LaunchPolicy{}, fmt.Errorf("invalid image LABEL '%s'; contact the image author", memoryMonitoring) | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
repeated from above?
/gcbrun |
jkl73
approved these changes
Aug 14, 2024
CS operators can use tee-dev-shm-size to increase the size of the /dev/shm mount for the workload.
Add tmpfs mount support, with destination and size options. Add launchermount package and LaunchPolicy for AllowedMountDestinations. launchermount has a new Mount interface and a TmpfsMount type. LaunchPolicy now supports tee.launch_policy.allow_mount_destination, which specifies allowed parent filepaths to mount on via a PATH-like string.
This tests the allowed mount points for tmpfs mounts and /dev/shm size.
/gcbrun |
Merging past the failing lint, since it's on untouched code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CS operators can use tee-dev-shm-size to increase the size of the /dev/shm mount for the workload.
CS operators can use
tee-mount
to specify tmpfs mounts in the running container. For example:type=tmpfs,source=tmpfs,destination=/tmp;type=tmpfs,source=tmpfs,destination=/tmp2,size=12345
.This interacts with the
tee.launch_policy.allow_mount_destination
launch policy that configures what the allowable mount points for a given workload are.