Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put the versions of dependencies directly in Gradle Metadata #6664

Closed
wants to merge 1 commit into from

Conversation

jjohannes
Copy link
Contributor

@jjohannes jjohannes commented Aug 2, 2023

This makes the version handling in POM and Gradle Metadata more similar. See #6654 (comment)

This would allow reverting 71a16d5

This makes the version handling in POM and Gradle Metadata more similar.
See google#6654 (comment)
@cgdecker cgdecker requested a review from cpovirk August 2, 2023 16:04
@cgdecker cgdecker added the P3 label Aug 2, 2023
@cpovirk cpovirk added type=enhancement Make an existing feature better package=general P2 and removed P3 labels Aug 2, 2023
@cpovirk cpovirk self-assigned this Aug 2, 2023
copybara-service bot pushed a commit that referenced this pull request Aug 2, 2023
This makes the version handling in POM and Gradle Metadata more similar.
See #6654 (comment)

We expect this to fix #6657, though we don't fully understand it.

Fixes #6664

RELNOTES=Changed Gradle Metadata to include dependency versions directly. This may address ["Could not find `some-dependency`" errors](#6657) that some users have reported (which might be a result of users' excluding `guava-parent`).
PiperOrigin-RevId: 553180806
@copybara-service copybara-service bot closed this in c6d35cf Aug 2, 2023
@jjohannes jjohannes deleted the versions-in-module-info branch January 8, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 package=general type=enhancement Make an existing feature better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants