Metrics server flag no longer exists

[jseba]

Description

I'm trying to do some memory usage debugging and tried to enable the metrics server according to the documentation here. But that flag no longer seems to exist and when I tried with the Docker instructions it was also failing the same way, with flag provided but not defined: -metrics-server.

Is the documentation out of date or is the metrics server broken?

Steps to reproduce

1. Follow https://gvisor.dev/docs/user_guide/observability/ to set up a Docker runtime with the metrics server flag
2. Restart Docker daemon
3. Run a test container with that runtime

runsc version

master

docker version (if using docker)

Client: Docker Engine - Community
 Version:           26.1.1
 API version:       1.45
 Go version:        go1.21.9
 Git commit:        4cf5afa
 Built:             Tue Apr 30 11:48:04 2024
 OS/Arch:           linux/arm64
 Context:           default

Server: Docker Engine - Community
 Engine:
  Version:          26.1.1
  API version:      1.45 (minimum version 1.24)
  Go version:       go1.21.9
  Git commit:       ac2de55
  Built:            Tue Apr 30 11:48:04 2024
  OS/Arch:          linux/arm64
  Experimental:     false
 containerd:
  Version:          1.6.31
  GitCommit:        e377cd56a71523140ca6ae87e30244719194a521
 runc:
  Version:          1.1.12
  GitCommit:        v1.1.12-0-g51d5e94
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0

uname

Linux devbox 6.1.0-18-arm64 #1 SMP Debian 6.1.76-1 (2024-02-01) aarch64 GNU/Linux

kubectl (if using Kubernetes)

No response

repo state (if built from source)

No response

runsc debug logs (if available)

No response

[ayushr2]

I think you misspelled --metric-server:

gvisor/runsc/config/flags.go

Line 64 in 0bf4e9f

flagSet.String("metric-server", "", "if set, export metrics on this address. This may either be 1) 'addr:port' to export metrics on a specific network interface address, 2) ':port' for exporting metrics on all interfaces, or 3) an absolute path to a Unix Domain Socket. The substring '%ID%' will be replaced by the container ID, and '%RUNTIME_ROOT%' by the root. This flag must be specified in both `runsc metric-server` and `runsc create`, and their values must match.")

(drop the "s" after "metrics")

[jseba]

Well that's embarrassing 🤦.

Any chance you have a chat somewhere I can ask dumb questions like this in the future? 😄

[ayushr2]

No issues :)

Any chance you have a chat somewhere

We do have https://gitter.im/gvisor/community, but it seems like it is quite inactive. In the meantime, you could use https://groups.google.com/g/gvisor-users for questions.