runsc: add global profile collection flags #6579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prattmic
force-pushed
the
runsc_do_profile
branch
from
91419a5
to
1548f5a
Compare
prattmic
force-pushed
the
runsc_do_profile
branch
from
1548f5a
to
4cc534c
Compare
nlacasse
approved these changes
Sep 14, 2021
|
Thanks for doing this! Being able to directly profile for the duration of a container execution will be really useful. Also @zkoopmans you might be interested in this change, afaik the current benchmarking library uses runsc debug and parallely runs the container. This might be a better way of collecting profiles. |
prattmic
force-pushed
the
runsc_do_profile
branch
from
4cc534c
to
ad052b7
Compare
prattmic
added
ready to pull
and removed
ready to pull
kokoro:run
|
@ayushr2 updating the website is a good idea. I'll send another PR for that. |
copybara-service bot
pushed a commit
that referenced
this pull request
Sep 15, 2021
Add global flags -profile-{block,cpu,heap,mutex} and -trace which
enable collection of the specified profile for the entire duration of a
container execution. This provides a way to definitively start profiling
before that application starts, rather than attempting to race with an
out-of-band `runsc debug`.
Note that only the main boot process is profiled.
Fixes #220
FUTURE_COPYBARA_INTEGRATE_REVIEW=#6579 from prattmic:runsc_do_profile ad052b71469658032cff5f8a95f482156976c66f
PiperOrigin-RevId: 396660344
Add global flags -profile-{block,cpu,heap,mutex} and -trace which
enable collection of the specified profile for the entire duration of a
container execution. This provides a way to definitively start profiling
before that application starts, rather than attempting to race with an
out-of-band `runsc debug`.
Note that only the main boot process is profiled.
This exposed a bug in Task.traceExecEvent: a crash when tracing and
-race are enabled. traceExecEvent is called off of the task goroutine,
but uses the Task as a context, which is a violation of the Task
contract. Switching to the AsyncContext fixes the issue.
Fixes google#220
prattmic
force-pushed
the
runsc_do_profile
branch
from
ad052b7
to
bd296e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add global flags -profile-{block,cpu,heap,mutex} and -trace which
enable collection of the specified profile for the entire duration of a
container execution. This provides a way to definitively start profiling
before that application starts, rather than attempting to race with an
out-of-band
runsc debug.Note that only the main boot process is profiled.
Fixes #220