-
Notifications
You must be signed in to change notification settings - Fork 179
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove notifications as it is not used.
- Loading branch information
Sepand Parhami
committed
Oct 1, 2016
1 parent
d31e2a4
commit f7f6b1c
Showing
2 changed files
with
0 additions
and
38 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
f7f6b1c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you remove the Hook documented here?
http://google.github.io/incremental-dom/#hooks/added-removed-nodes
If yes, please indicate if there is any other way of knowing when a node was removed from the DOM. This will definitely be necessary for detaching event handlers and references.
f7f6b1c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lastest version, 0.5.1 still has the hook. This has been removed from the development branch. I plan on adding a different way to listen for created / deleted nodes for the next release.
f7f6b1c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sparhami regarding the different way to listen for created / deleted nodes mentioned, is it already proposed anywhere? I could not find the issue, thy.
f7f6b1c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is mentioned as part of #254, do not currently have a separate issue for it.