Skip to content

Commit

Permalink
Remove notifications as it is not used.
Browse files Browse the repository at this point in the history
  • Loading branch information
Sepand Parhami committed Oct 1, 2016
1 parent d31e2a4 commit f7f6b1c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 38 deletions.
1 change: 0 additions & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,5 +40,4 @@ export {
applyAttr,
applyProp
} from './src/attributes';
export { notifications } from './src/notifications';
export { importNode } from './src/node_data';
37 changes: 0 additions & 37 deletions src/notifications.js

This file was deleted.

4 comments on commit f7f6b1c

@jvitela
Copy link

@jvitela jvitela commented on f7f6b1c Oct 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you remove the Hook documented here?
http://google.github.io/incremental-dom/#hooks/added-removed-nodes

If yes, please indicate if there is any other way of knowing when a node was removed from the DOM. This will definitely be necessary for detaching event handlers and references.

@sparhami
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lastest version, 0.5.1 still has the hook. This has been removed from the development branch. I plan on adding a different way to listen for created / deleted nodes for the next release.

@eduardolundgren
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sparhami regarding the different way to listen for created / deleted nodes mentioned, is it already proposed anywhere? I could not find the issue, thy.

@sparhami
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is mentioned as part of #254, do not currently have a separate issue for it.

Please sign in to comment.