Initial API for updating attributes and properties. #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
reviewed
Apr 28, 2017
| /** | ||
| * @type {function(!Element, string, *)} | ||
| */ | ||
| const queueAttribute = queueChange.bind(null, applyAttr); |
There was a problem hiding this comment.
Nit: Function#bind is considerably slower than using a closure.
| bufferAttribute, | ||
| bufferProperty, | ||
| queueAttribute, | ||
| queueProperty, |
There was a problem hiding this comment.
Why are we exposing the queues here?
| * Immediately applies any diffs for the current element and buffered | ||
| * attributes. | ||
| */ | ||
| const applyUpdates = function() { |
There was a problem hiding this comment.
Nit: rename it to applyBuffer if we're calling it bufferAttribute and bufferProperty?
|
How would static attributes/properties work under this model? Are we removing them entirely? |
|
Closing in favor of #408, might revisit splitting attributes and properties in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flow is faster than
elementOpenStart()+attr()+elementOpenEnd()while allowing consumers of the library to be explicit rather than needing to specify a hook. This also exposes the ability to simply queue changes and flush them later, which can be beneficial in high mutation cases.