Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't zero out origin of uninitialized bytes in kmsan_internal_set_shadow_origin() #70

Open
ramosian-glider opened this issue Dec 11, 2019 · 1 comment
Open

Don't zero out origin of uninitialized bytes in kmsan_internal_set_shadow_origin() #70

ramosian-glider opened this issue Dec 11, 2019 · 1 comment
Labels
enhancement linux-6.1 Issue present in the Linux 6.1 release

Comments

@ramosian-glider
Copy link
Member

The following test:

char buf[4];
kmsan_unpoison_shadow(buf, 1);
kmsan_check_memory(buf, 4);

doesn't report any errors.
This could be related to kmsan_unpoison_shadow() zeroing out the origin despite there still are uninitialized bytes.
We must only zero out an origin iff the shadow is also zeroed out.
ramosian-glider added a commit that referenced this issue Dec 11, 2019
@ramosian-glider
kmsan: delete the somewhat perfectionist TODOs from kmsan.c
f06f07c 
A potential problem in kmsan_internal_set_origin() is now tracked in
#70
@ramosian-glider ramosian-glider changed the title Don't zero out origin of uninitialized bytes in kmsan_internal_set_origin() Don't zero out origin of uninitialized bytes in kmsan_internal_set_shadow_origin() Nov 10, 2022
@ramosian-glider
Copy link
Member Author

This is still valid.

@ramosian-glider ramosian-glider added the linux-6.1 Issue present in the Linux 6.1 release label Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement linux-6.1 Issue present in the Linux 6.1 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ramosian-glider