Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Cast type explicitly #1155

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: Cast type explicitly #1155

wants to merge 1 commit into from

Conversation

hebasto
Copy link

@hebasto hebasto commented Nov 5, 2023

This change:

  • Is a pure refactor without altering the assembly code, which might be verified, for example, with the https://godbolt.org/ service.
  • Fixes warning C4244 when compiling with MSVC at production quality W3 warning level:
... util\coding.cc(59,18): warning C4244: '=': conversion from 'uint64_t' to 'uint8_t', possible loss of data

@hebasto
refactor: Cast type explicitly
524d270 
This change:
 - Is a pure refactor without altering the assembly code, which
   might be verified, for example, with the https://godbolt.org/
   service.
 - Fixes warning C4244 when compiling with MSVC at production quality
   W3 warning level.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hebasto