Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure and update #1055

Merged
merged 13 commits into from
Aug 20, 2020
Merged

Restructure and update #1055

merged 13 commits into from
Aug 20, 2020

Conversation

rsheeter
Copy link
Collaborator

@rsheeter rsheeter commented Aug 18, 2020

Restructure the repo, provide a script to update it, update it.

Fixes #1042
Fixes #1054
Fixes #1056

@google-cla google-cla bot added the cla: yes label Aug 18, 2020
@danny-laa
Copy link

danny-laa commented Aug 18, 2020

Can you also upload those icons removed from the official website, like the icons in the following list?

["1k_plus","19mp","18mp","17mp","16mp","15mp","14mp","13mp","12mp","11mp","10mp","10k","1k","2k_plus","24mp","23mp","22mp","21mp","20mp","2mp","2k","3k_plus","3mp","3k","4k_plus","4mp","5mp","5k_plus","5k","6mp","6k_plus","6k","7k_plus","7mp","7k","8k_plus","8mp","8k","9k_plus","9mp","9k","auto_stories","auto_fix_off","auto_fix_normal","auto_fix_high","auto_awesome_motion","auto_awesome_mosaic","auto_awesome","attractions","assistant_navigation","assistant_direction","approval","app_registration","animation","airplanemode_on","airplanemode_off","add_to_drive","add_moderator","add_link","add_chart","add_call","bus_alert","brunch_dining","breakfast_dining","border_color","bookmark_outline","bolt","block_flipped","bakery_dining","badge","connected_tv","confirmation_num","compress","closed_caption_off","circle_notifications","circle","cell_wifi","celebration","cases","car_repair","car_rental","dry_cleaning","drive_folder_upload","drive_file_rename_outline","drive_file_move_outline","drive_file_move","do_not_disturb_on","do_not_disturb_off","do_not_disturb_alt","do_not_disturb","dnd_forwardslash","dirty_lens","directions_train","directions_ferry","dinner_dining","device_thermostat","delivery_dining","dashboard_customize","dangerous","exposure_minus_2","exposure_minus_1","expand","enhance_photo_translate","electric_rickshaw","edit_off","format_underline","format_color_text","format_color_fill","fit_screen","fire_hydrant","filter_list_alt","file_upload","file_present","file_download_done","file_download","festival","favorite_outline","face_retouching_natural","grid_view","goat","home_filled","highlight_remove","headset_off","hdr_enhanced_select","hardware","hail","ios_share","invert_colors_on","inventory","info_outline","imagesearch_roller","icecream","keyboard_control","lunch_dining","logout","lock_outline","lock_clock","location_pin","location_history","local_restaurant","local_print_shop","local_attraction","liquor","lightbulb_outline","lightbulb","leave_bags_at_home","label_outline","label_important_outline","my_library_music","my_library_books","my_library_add","multitrack_audio","mp","motorcycle","motion_photos_off","monitor","mode_edit","mic_external_on","mic_external_off","messenger_outline","messenger","mark_as_unread","margin","now_widgets","now_wallpaper","notifications_on","no_meals_ouline","nightlight_round","nightlife","network_wifi","network_cell","outgoing_mail","outbox","offline_share","play_disabled","play_circle_fill","pivot_table_chart","pie_chart_outlined","photo_camera_front","photo_camera_back","person_add_alt","perm_device_info","perm_contact_cal","park","panorama_wide_angle_select","panorama_vertical_select","panorama_photosphere_select","panorama_photosphere","panorama_horizontal_select","panorama_fisheye","padding","quick_contacts_mail","quick_contacts_dialer","rtt","reset_tv","replay_circle_filled","repeat_one_on","repeat_on","remove_moderator","remove_done","recommend","ramen_dining","railway_alert","radio_button_on","radio_button_off","system_update_tv","switch_account","swipe","swap_vert_circle","stream","stacked_bar_chart","sim_card_alert","signal_wifi_0_bar","signal_cellular_0_bar","shuffle_on","shield","settings_display","sentiment_neutral","send_to_mobile","send_and_archive","segment","sd","screen_search_desktop","schedule_send","saved_search","trending_neutral","thumb_up_off_alt","thumb_down_off_alt","theater_comedy","taxi_alert","takeout_dining","tag","upload_file","volunteer_activism","view_in_ar","view_comfortable","video_collection","workspaces_outline","workspaces_filled","wb_twighlight","wb_shade","waterfall_chart","wallet_travel","wallet_membership","wallet_giftcard"]

@danny-laa Can't seem to see a reply option; I'm going to move this request to a standalone issue.

@danny-laa
Copy link

Can you also upload historical versions of icons too? For example, version 1 of 3d_rotation is still available in the API.

https://fonts.gstatic.com/s/i/materialicons/3d_rotation/v1/24px.svg

@user72356
Copy link

Are you also planning to include the SVG version of all 5 themes? I can only see the "Filled" icons in SVG format. Thanks

@rsheeter
Copy link
Collaborator Author

@danny-laa I don't intend to upload historical versions. You could try just walking back to 1 from the current version but it won't get you all versions that ever existed as some may never have been loaded into fonts.gstatic.com and it may get you some that were broken.

@gb1337 svgs will be provided for all themes except where a given icon is not implemented for that theme. Sample file layout:

# src/<category>/<icon name>/<stylistic set>/<XX>px.svg
src/action/3d_rotation/materialiconsoutlined/24px.svg
src/action/3d_rotation/materialiconsround/24px.svg
src/action/3d_rotation/materialiconssharp/24px.svg
src/action/3d_rotation/materialicons/24px.svg
src/action/3d_rotation/materialiconstwotone/24px.svg

@rsheeter
Copy link
Collaborator Author

Reviewers list isn't loading; reviewed by @EsoHasInsomnia

@user72356
Copy link

@rsheeter Thank you for the update. I have 2 comments:

  • IMO the subfolder name for the "Rounded" theme should be "XXXrounded" and not "XXXround".

  • The .svg files contain 2 paths, similar to the "design" version of the previous folder structure. The "production" version had that extra path removed to make the SVG a little lighter. I think the path is some sort of invisible background that is unused. Can I suggest that this extra path be removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants