Make dependabot grouping work on all update types #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdarkhan
force-pushed
the
dependabot-group
branch
from
254350e
to
578bdd2
Compare
mgeisler
approved these changes
Feb 6, 2024
.github/dependabot.yml
Outdated
| patch: | ||
| update-types: | ||
| - patch | ||
| groups: |
There was a problem hiding this comment.
I'm not sure you can use groups as a top-level item like this. My impression was that it has to be nested under an item in updates. See how groups is mentioned under updates here: Configuration options for the dependabot.yml file.
In Comprehensive Rust, I simply duplicated the groups for each type of update.
There was a problem hiding this comment.
I see. I based my approach on the example 1 in the official doc s but it might be just not a full example. I just amended the approach and duplicated the definitions.
kdarkhan
force-pushed
the
dependabot-group
branch
from
578bdd2
to
d776f47
Compare
The initial version defined groups only for cargo deps. Because of that, we have 2 separate PRs related to `github-actions`. This ensures that grouping logic works for all deps.
kdarkhan
force-pushed
the
dependabot-group
branch
from
d776f47
to
9509ec3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial version defined groups only for cargo
deps. Because of that, we have 2 separate PRs related to
github-actions. This ensures that grouping logic works for all deps.