Skip to content

Commit

Permalink
Fix ENGINE_VERSION in mozc_version_template.bzl
Browse files Browse the repository at this point in the history
This is a follow up CL to a previous CL [1], which should have removed
NACL_DICTIONARY_VERSION, and other previous CLs [2][3], which should
have updated ENGINE_VERSION.

Note that not updating ENGINE_VERSION is not immediately problematic
because dynamic dictoinary update is not enabled in OSS Mozc.  That
said, the current ENGINE_VERSION is 24 and correcting it should still
make sense.

This CL also add a copyright header and license notice to
mozc_version_template.bzl just in case.

 [1]: 5b9c1ed
 [2]: c4a2d46
 [3]: 25f3fcf

BUG=
TEST=
REF_BUG=
REF_CL=123078429,123191246,127786726,131517988
REF_TIME=2016-08-28T01:31:07-07:00
REF_TIME_RAW=1472373067 -0700
  • Loading branch information
yukawa committed Aug 28, 2016
1 parent 6ec2f57 commit d44d064
Showing 1 changed file with 32 additions and 7 deletions.
39 changes: 32 additions & 7 deletions src/data/version/mozc_version_template.bzl
Original file line number Diff line number Diff line change
@@ -1,20 +1,45 @@
# -*- coding: utf-8 -*-
# Copyright 2010-2016, Google Inc.
# All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions are
# met:
#
# * Redistributions of source code must retain the above copyright
# notice, this list of conditions and the following disclaimer.
# * Redistributions in binary form must reproduce the above
# copyright notice, this list of conditions and the following disclaimer
# in the documentation and/or other materials provided with the
# distribution.
# * Neither the name of Google Inc. nor the names of its
# contributors may be used to endorse or promote products derived from
# this software without specific prior written permission.
#
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

MAJOR=2
MINOR=18
BUILD=2597
BUILD=2598
REVISION=102
# CAUTION: NACL_DICTIONARY_VERSION is going to be migrated to ENGINE_VERSION.
# NACL_DICTIONARY_VERSION is the target version of the system dictionary to be
# downloaded by NaCl Mozc.
# TODO(noriyukit): Migrate this version to ENGINE_VERSION.
NACL_DICTIONARY_VERSION=22
# This version represents the version of Mozc IME engine (converter, predictor,
# etc.). This version info is included both in the Mozc server and in the Mozc
# data set file so that the Mozc server can accept only the compatible version
# of data set file. The engine version must be incremented when:
# * POS matcher definition and/or conversion models were changed,
# * New data are added to the data set file, and/or
# * Any changes that loose data compatibility are made.
ENGINE_VERSION=22
ENGINE_VERSION=24
# This version is used to manage the data version and is included only in the
# data set file. DATA_VERSION can be incremented without updating
# ENGINE_VERSION as long as it's compatible with the engine.
Expand Down

0 comments on commit d44d064

Please sign in to comment.