Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate base/scoped_ptr.h #219

Closed
GoogleCodeExporter opened this issue Apr 22, 2015 · 5 comments
Closed

Deprecate base/scoped_ptr.h #219

GoogleCodeExporter opened this issue Apr 22, 2015 · 5 comments
Labels
auto-migrated Maintainability OpSys-All Priority-Medium Type-Notice

Comments

@GoogleCodeExporter
Copy link 

base/scoped_ptr.h, which has been there since the initial release of OSS Mozc 
(*1),
is under deprecation process and will be removed from code tree in a future 
release.  If you derivative project is still including "base/scoped_ptr.h", 
please stop doing this and switch to std::unique_ptr<T>.

*1: 
https://code.google.com/p/mozc/source/browse/trunk/src/base/scoped_ptr.h?r=10

Background:
We have been gradually enabling C++11 in Mozc since Dec 2012.  As a part of 
this effort, we are now replacing mozc::scoped_ptr<T> with std::unique_ptr<T>.  
As of r192, this transition is completed at least in win32/* and unix/*.

The important thing is that base/scoped_ptr.h will be removed once the 
transition is completed.  Please stop including "base/scoped_ptr.h" in your 
project and switch to std::unique_ptr<T> to avoid unnecessary build breakage.

Thank you for your cooperation.

Original issue reported on code.google.com by [email protected] on 24 May 2014 at 6:47
@GoogleCodeExporter
Copy link
Author

Original comment by [email protected] on 26 May 2014 at 2:26

  • Changed title: Deprecate base/scoped_ptr.h

@GoogleCodeExporter
Copy link
Author

Original comment by [email protected] on 3 Aug 2014 at 8:24

@GoogleCodeExporter
Copy link
Author

Original comment by [email protected] on 13 Dec 2014 at 6:07

@GoogleCodeExporter
Copy link
Author

Original comment by [email protected] on 13 Dec 2014 at 6:08

@GoogleCodeExporter
Copy link
Author

Original comment by [email protected] on 13 Dec 2014 at 6:08

This was referenced Apr 22, 2015
Closed
Closed
yukawa added a commit that referenced this issue Oct 25, 2015
@yukawa
Deprecate scoped_ptr part 1.
d56d5db 
With this CL, scoped_ptr is replaced with std::unique_ptr mainly in the
following directories.
 - src/engine/
 - src/usage_stats/

BUG=#219
TEST=unittest
REF_BUG=9164610
REF_CL=84942345,84942768,84943699
yukawa pushed a commit that referenced this issue Oct 25, 2015
@yukawa
Deprecate scoped_ptr part 2.
b3330bb 
With this CL, scoped_ptr is replaced with std::unique_ptr mainly in the
following directories.
 - src/dictionary/file/
 - src/gui/
 - src/server/
 - src/storage/

BUG=#219
TEST=unittest
REF_BUG=9164610
REF_CL=84944931,84944947,84945576,85032863,85033860
yukawa pushed a commit that referenced this issue Oct 25, 2015
@yukawa
Deprecate scoped_ptr part 3.
1ed3119 
With this CL, scoped_ptr is replaced with std::unique_ptr mainly in the
following directories.
 - src/chrome/
 - src/client/
 - src/composer/
 - src/converter/
 - src/handwriting/
 - src/mac/
 - src/prediction/
 - src/renderer/
 - src/rewriter/
 - src/session/

BUG=#219
TEST=unittest
REF_BUG=9164610
REF_CL=85037361,85040383,85120717,85123903,85124773,85125239,85125883,85128985,85135671,85140884
hiroyuki-komatsu added a commit that referenced this issue Oct 26, 2015
@hiroyuki-komatsu @yukawa
Fix build failure caused by 1ed3119.
7a8cb1b 
This is a follow up CL for 1ed3119.

This CL replaces NULL with nullptr and stops initializing unique_ptr
with NULL/nullptr.

BUG=#219
TEST=unittest
REF_BUG=9164610
REF_CL=85307407
yukawa pushed a commit that referenced this issue Oct 26, 2015
@sumita12 @yukawa
Fix build break caused by 26d5e5b.
27cba8e 
This is a follow up CL for 26d5e5b.

No impact in production binaries is intended.

BUG=#219
TEST=
REF_BUG=19010851
REF_CL=91757348
yukawa pushed a commit that referenced this issue Nov 3, 2015
@yukawa
Deprecate scoped_ptr part 4.
ff953f4 
With this CL, scoped_ptr is replaced with std::unique_ptr in the
following directories.
 - src/android/
 - src/base/
 - src/config/
 - src/data_manager/
 - src/dictionary/
 - src/ipc/
 - src/testing/

This is just a mechanical refactoring.  No behavior change is intended.

BUG=#219
TEST=unittest
REF_BUG=9164610
REF_CL=85302962,85303257,85303597,85305350,85305985,85306371,85309721,85312175,85315394
yukawa pushed a commit that referenced this issue Nov 3, 2015
@yukawa
Deprecate scoped_ptr part 5.
b0302a1 
This CL removes scoped_ptr.h, which is no longer used.

This is just a removal of an unused file.  No behavior change is
intended.

BUG=#219
TEST=unittest
REF_BUG=9164610
REF_CL=85316226
@yukawa yukawa mentioned this issue Nov 3, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auto-migrated Maintainability OpSys-All Priority-Medium Type-Notice
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GoogleCodeExporter