Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session_handler_scenario_test is flaky in Linux build on Travis-CI #317

Closed
yukawa opened this issue Nov 2, 2015 · 1 comment
Closed

session_handler_scenario_test is flaky in Linux build on Travis-CI #317

yukawa opened this issue Nov 2, 2015 · 1 comment
Assignees
@yukawa
Labels
OpSys-Linux Type-Defect

Comments

@yukawa
Copy link
Collaborator

yukawa commented Nov 2, 2015

Version: as of b393fbd
Platform: Linux desktop

We have seen so many random test failures in fix_session_handler_scenario_test only in Linux build on Travis-CI. Something is going wrong there.

  • Job # 209.2
    • data/test/session/scenario/delete_history.txt:23
  • Job # 208.2
    • data/test/session/scenario/delete_history.txt:23
  • Job # 206.2
    • data/test/session/scenario/b8690065_scenario.txt:21
    • data/test/session/scenario/delete_history.txt:23
    • data/test/session/scenario/delete_history.txt:27
    • data/test/session/scenario/delete_history.txt:28
    • data/test/session/scenario/delete_history.txt:35
    • data/test/session/scenario/revert.txt:17
@yukawa yukawa self-assigned this Nov 2, 2015
@yukawa yukawa changed the title fix_session_handler_scenario_test is flaky in Linux build on Travis-CI session_handler_scenario_test is flaky in Linux build on Travis-CI Nov 2, 2015
hiroyuki-komatsu added a commit that referenced this issue Nov 9, 2015
@hiroyuki-komatsu @yukawa
More removals of GET_CONFIG.
fa02514 
This CL is a preparation of Singleton<Config> removal.

GET_CONFIG relies on process global Singleton<Config>, which has caused
many troubles.  With this CL, many conversion-related methods will be
refactored to receive ConversionRequest to access settings.

Hopefully this can help to address or at least mitigate test flakiness
like #317.

BUG=#317
TEST=unittest
REF_BUG=19010851,19188911
REF_CL=87318105
yukawa added a commit that referenced this issue Nov 14, 2015
@yukawa
Try to fix flaky session_handler_scenario_test.
d9d63a1 
For unknown reasons, session_handler_scenario_test in on Travis CI is
really flaky.  This is a speculative fix for that flakiness.

Although the reason why session_handler_scenario_test is flaky only on
Travis CI is still unknown, there are actually two questionable points:
 1. CharacterFormMamanger is not reloaded among scenario tests.
 2. SessionHandlerTestBase::TearDown is not called.

This CL addresses above two points.

BUG=#317
TEST=unittest
REF_BUG=19188911
REF_CL=107067222
@yukawa yukawa mentioned this issue Nov 14, 2015
Merged
@yukawa yukawa closed this as completed in 2379560 Nov 14, 2015
@yukawa
Copy link
Collaborator Author

yukawa commented Nov 14, 2015

Hmm, b8690065_scenario.txt still fails in build 315.2. Reopening.

@yukawa yukawa reopened this Nov 14, 2015
@yukawa yukawa closed this as completed in 602550f Nov 28, 2015
yukawa added a commit that referenced this issue Nov 28, 2015
@yukawa
Merge pull request #335 from google/attempt_to_fix_317
24662ba 
Attempt to fix #317 (2nd try)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yukawa yukawa

Labels
OpSys-Linux Type-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yukawa