Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some reading corrections #1069

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Add some reading corrections #1069

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b645390
Add some reading corrections
tats-u Oct 6, 2024
4a771d9
Add Tsuruma Central Library
tats-u Oct 6, 2024
bed89aa
Remove controversial correction candidate
tats-u Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/data/dictionary_oss/reading_correction.tsv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,3 +748,7 @@
出音 でおと しゅっとん
琴電 きんでん ことでん
博士課程 はかせかてい はくしかてい
上側 うえがわ うわがわ
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

上側(うえがわ) can be added as a word instead of the correction.
How about removing this line from this PR and focus other corrections?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, even Google Japanese Input doesn't register "上側" as "うえがわ".

  • うわがわ: Both Mozc & Google Japanese Input
  • うわかわ: Only Google Japanese Input
  • うえがわ & うえかわ: Neither

Copy link
Contributor Author

@tats-u tats-u Oct 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither of Digital Dai Jisen or Meikyo Japanese Dictionary register "うえがわ" or "うえかわ".
I have to look into Kojien or Japan Japanese Large Dictionary (日本国語大辞典) (or similar large dictionaries) though.
If even both didn't register either, would you change your opinion?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People widely use "うえがわ" too. I'd prefer adding it as a word, but not a correction.

https://www.google.com/search?q=%E4%B8%8A%E5%81%B4+%22%E3%81%86%E3%81%88%E3%81%8C%E3%82%8F%22

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kojien and Nihon Kokugo Dai Jiten adopt "うわかわ" ("うわがわ" is an alternative pronunciation).
No "うえがわ" in there.
It's controversial, so I removed it from this PR.

鶴舞公園 つるまいこうえん つるまこうえん
千種高等学校 ちくさこうとうがっこう ちぐさこうとうがっこう
名古屋市鶴舞中央図書館 なごやしつるまいちゅうおうとしょかん なごやしつるまちゅうおうとしょかん