Replace gclient/DEPS with git sub-modules. #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this CL, we check out dependent third party source code by using git sub-modules rather than gclient/DEPS, which allows us to drop hard dependency on gclient when checking out and building Mozc. Although some prebuilt binaries in gclient are still useful for some platforms, in principle OSS Mozc no longer depends on gclient. This is a clean-up of source checking out process. Build artifacts should not be affected with this change. BUG= TEST=unittest REF_BUG= REF_CL=
yukawa
added a commit
that referenced
this pull request
Sep 19, 2015
Replace gclient/DEPS with git sub-modules.
yukawa
added a commit
that referenced
this pull request
Aug 22, 2016
OSS Mozc no longer uses 'gclient'. The comment about how to check out 'gyp' needs to be updated with git submodule. BUG=#300 TEST= REF_BUG= REF_CL=129602172,130240858 REF_TIME=2016-08-08T00:26:49-07:00 REF_TIME_RAW=1470641209 -0700
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now this is doable.
Still checking out dependent third party source code alongside with Mozc tree and statically linking to them are our preferred way, as since #299 is fixed, now we can use
Git Submodulesto check out those source code.In general Git Submodules has better support in git ecosystem hence this should make OSS Mozc more reusable and sustainable. Also, people no longer need to learn about gclient/DEPS, which is used only around Chromium ecosystem, just for building Mozc.