OSX build does not require Ninja yet. #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow up CL for 276fa5c, which mistakenly stated that OSX build requires Ninja. Although we still plan to use Ninja for OSX build as mentioned in #247, it is not yet done. Until then, we don't have to ask people to install Ninja when building Mozc for OSX. BUG=#247 TEST=unittest REF_BUG= REF_CL=
yukawa
added a commit
that referenced
this pull request
Sep 20, 2015
OSX build does not require Ninja yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until #247 is fixed, we don't need to ask people to install Ninja for building OSX binaries.