Fix a runtime crash in Mozc for Android. #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow up CL for 9cd4d36. The root cause of the runtime crash is that base/base.gyp:jni_proxy is not linked to libmozc.so only in OSS build because the link dependency on 'jni_proxy' target is specified in 'net/net.gyp' only when branding=="GoogleJapaneseInput". There are two different problems. 1. There are direct function invocations of base/android_jni_proxy.cc from android/jni/mozcjni.cc. Hence it's 'android/android.gyp:mozc' that should have declared the dependency on 'base/base.gyp:jni_proxy'. Declaring the dependency in 'net/net.gyp' does not make much sense. 2. With CL 96942303, 'base/base.gyp:jni_proxy' needs to be linked to libmozc.so even in OSS build. This CL addresses both of avobe issues. Closes #345. BUG=#345 TEST=compile REF_BUG=26369443 REF_CL=111290167
yukawa
added a commit
that referenced
this pull request
Jan 4, 2016
Fix a runtime crash in Mozc for Android.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #345 that was introduced by 9cd4d36.