Fix #361 #365
Merged
Fix #361 #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that |CANDIDATEFORM::rcArea| has been unexpectedly ignored when the IMM32 client also supports IMR_QUERYCHARPOSITION protocol. In short, the base position and exclude region for suggestion/conversion window should be determined by using different priority rules. Followings are expected orders of rules after this CL is applied. A. base position for suggestion: 1. IMR_QUERYCHARPOSITION 2. CANDIDATEFORM::ptCurrentPos (if CAN_USE_CANDIDATE_FORM_FOR_SUGGEST) 3. GUITHREADINFO::rcCaret 4. COMPOSITIONFORM::ptCurrentPos 5. The edge of the client window. B. base position for conversion: 1. IMR_QUERYCHARPOSITION 2. CANDIDATEFORM::ptCurrentPos 3. GUITHREADINFO::rcCaret 4. COMPOSITIONFORM::ptCurrentPos 5. The edge of the client window. C. exclude rect for suggestion: 1. CANDIDATEFORM::rcArea (if CAN_USE_CANDIDATE_FORM_FOR_SUGGEST) 2. IMR_QUERYCHARPOSITION + font height 3. GUITHREADINFO::rcCaret + font height 4. COMPOSITIONFORM::ptCurrentPos + font height 5. The client rect of the target window. D. exclude rect for conversion: 1. CANDIDATEFORM::rcArea 2. IMR_QUERYCHARPOSITION + font height 3. GUITHREADINFO::rcCaret + font height 4. COMPOSITIONFORM::ptCurrentPos + font height 5. The client rect of the target window. What has been broken is the 1st rule and 2nd rule of C and D. Previously we have mistakenly put higher priority on IMR_QUERYCHARPOSITION in those cases. BUG=#361 TEST=manually done REF_BUG=27394949 REF_CL=115815290
Strictly speaking, IMM32 spec never requires the application to update |CANDIDATEFORM| until IMN_OPENCANDIDATE is sent from the IME. In the case of Mozc, we intentionally do not send IMN_OPENCANDIDATE when the suggestion window is shown, because doing that can confuse some applications such as command prompt. That said, |CANDIDATEFORM::rcArea| is still a useful information that we want to rely on if it is guaranteed to be kept updated. For that purpose, we have maintained a list of applications which are known to keep |CANDIDATEFORM::rcArea| updated regardless of IMN_OPENCANDIDATE, and this CL adds "MozillaWindowClass" window class into the whitelist so that Firefox can be marked with CAN_USE_CANDIDATE_FORM_FOR_SUGGEST compatibility flag. BUG=#361 TEST=manually done REF_BUG=27394949 REF_CL=115815738
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to fix #361, two changes are needed; one is to fix a bug about how to calculate the exclusion rect, and the other is to use
CAN_USE_CANDIDATE_FORM_FOR_SUGGESTcompatibility flag for Firefox.See commit messages for details.