Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isMMapEnabled() always returns false if setMMapEnabled(f) never called #1967

Closed
philburk opened this issue Feb 27, 2024 · 1 comment · Fixed by #1968
Closed

isMMapEnabled() always returns false if setMMapEnabled(f) never called #1967

philburk opened this issue Feb 27, 2024 · 1 comment · Fixed by #1968
Labels

Comments

@philburk
Copy link
Collaborator

Oboe version: 1.8.1 and earlier
App name used for testing: OboeTester

Short description
Jiabin found an error in isMMapEnabled().
It returns a true if MMAP policy is set for MMAP on.
But if the policy is UNSPECIFIED then it returns false, even if MMAP is enabled in the system.

Steps to reproduce
I added logging to OboeTester and then ran this test before setMMapEnabled(f) was called.

  • print isMMapSupported()
  • print isMMapEnabled()

Expected behavior
If MMspSupported() then MMapEnabled() should also be true.

Actual behavior
isMMapEnabled() is false.

@philburk philburk added the bug label Feb 27, 2024
philburk added a commit that referenced this issue Feb 27, 2024
If policy is Unspecified then return isMMapSupported.

Fixes #1967
@philburk
Copy link
Collaborator Author

philburk commented Feb 27, 2024

Tracked internally in b/326989822 | P1 | Use AAudioExtensions to get/set mmap policy enabled does not work as expected

philburk added a commit that referenced this issue Feb 28, 2024
If policy is Unspecified then return isMMapSupported.

Fixes #1967
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant