Upgrade rust library dependencies and bump version #422
Conversation
fintelia
force-pushed
the
update-rust
branch
from
d957709
to
9aff92d
Compare
| let lat = rng.gen_range(-90.0, 90.0); | ||
| let lng = rng.gen_range(-180.0, 180.0); | ||
| let mut len = rng.gen_range(2, 15); | ||
| let lat = rng.gen_range(-90.0..90.0); |
There was a problem hiding this comment.
It looks like the prevailing convention with gen_range is to pass in the interval endpoints rather than a range. Unless this is backwards-compatible and there's some recommendation to change style in new usages, mind leaving as it was?
There was a problem hiding this comment.
It is actually more forceful than just a style recommendation. The underlying rand crate changed the function declaration so only the new version will even compile.
| @@ -9,7 +9,7 @@ keywords = ["geography", "geospatial", "gis", "gps", "olc"] | |||
| exclude = ["rust.iml"] | |||
|
|
|||
| [dependencies] | |||
| geo = "^0.4.3" | |||
| geo = "0.16.0" | |||
There was a problem hiding this comment.
This is effectively dropping support for versions < 0.16.0, right? Can you add some description of why that's desirable?
There was a problem hiding this comment.
Rust uses a slightly weird variant of semver so versions 0.4.x, 0.5.x, .... 0.16.x, 1.x.y, 2.x.y are all mutually incompatible (you can see more details here). The net result is that previously the library only supported versions 0.4.x and after this change will support only 0.16.x.
|
Now I believe @JamesFysh is the only one that can publish a new version to crates.io. (Side note: it might make sense to add additional people or a GitHub team as owners so you don't lose access.) |
The Rust library depends on rather outdated versions of
geoandrandso this PR upgrades to the most recent ones. To be usable with the wider ecosystem, a new version will have to be pushed to crates.io so I've bumped the library version accordingly.