Fix building CPython after python/cpython#107026 #10758
Conversation
`Modules/_xxtestfuzz/fuzzer.c` in CPython started using private API in python/cpython@89f9875#diff-a22ac7579f23068e0c6bcacf1086ee962fdf8e68725cf0510b42d0a389cf1efd. This made fuzzing builds fail https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=60831. Including needed header files fixes the error.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
illia-v is a new contributor to projects/cpython3. The PR must be approved by known contributors before it can be merged. The past contributors are: jonathanmetzman, gpshead, DavidKorczynski, oliverchang, devtty1er, Dor1s, ammaraskar (unverified), alex (unverified), ssbr (unverified) |
@hogo6002 Can we filter out certain names from this list? A lot of these are maintainers that do mass changes but don't have particular knowledge of the project (me for example) |
|
Other than that, the list is great |
|
@ammaraskar @alex @gpshead do you approve? |
|
LGTM |
|
If this builds, it looks ok to me.
…On Mon, Jul 31, 2023, 11:32 AM Ammar Askar ***@***.***> wrote:
LGTM
—
Reply to this email directly, view it on GitHub
<#10758 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAGBHYXIKVVQ732UVTONLXS7FYRANCNFSM6AAAAAA2323HYM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sure, I will remove maintainers from this list. |
Modules/_xxtestfuzz/fuzzer.cin CPython started using private API in python/cpython@89f9875#diff-a22ac7579f23068e0c6bcacf1086ee962fdf8e68725cf0510b42d0a389cf1efd.This made fuzzing builds fail https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=60831.
Including needed header files fixes the error.