Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[infra] Skip code coverage job for gofuzz projects (#2714). #2818

Merged
merged 1 commit into from
Sep 9, 2019
Merged

[infra] Skip code coverage job for gofuzz projects (#2714). #2818

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions infra/gcb/build_and_run_coverage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@
# Link where to upload code coverage report files to.
UPLOAD_URL_FORMAT = 'gs://' + COVERAGE_BUCKET_NAME + '/{project}/{type}/{date}'

# TODO(#2817): gofuzz projects to skip code coverage job for.
GO_FUZZ_PROJECTS = ['golang', 'syzkaller']


def skip_build(message):
"""Exit with 0 code not to mark code coverage job as failed."""
Expand All @@ -66,6 +69,10 @@ def get_build_steps(project_dir):
if project_yaml['disabled']:
skip_build('Project "%s" is disabled.' % project_name)

if project_name in GO_FUZZ_PROJECTS:
skip_build('Project "%s" uses gofuzz, coverage is not supported yet.' %
project_name)

fuzz_targets = get_targets_list(project_name)
if not fuzz_targets:
skip_build('No fuzz targets found for project "%s".' % project_name)
Expand Down