[esp-v2]: Fix broken builds by changing spawn strategy #3485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Example failure](https://oss-fuzz-build-logs.storage.googleapis.com/log-8eabbac0-bb8f-4f90-a840-f23efe427e0e.txt) This only occurs on the fuzzers for some reason, not on Travis CI. Error is similar to bazelbuild/bazel#5640. Change spawn strategy to `sandboxed` to work around this. Not sure why it was `local` to begin with (other than a slight performance improvement). Tested locally to ensure this spawn strategy will work. ``` python infra/helper.py build_fuzzers --sanitizer address --engine libfuzzer --architecture x86_64 esp-v2 ``` Signed-off-by: Teju Nareddy <[email protected]>
Dor1s
approved these changes
Mar 9, 2020
|
merging since the failure reportedly didn't occur in Travis anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example failure
This only occurs on the fuzzers for some reason, not on Travis CI. Error is similar to bazelbuild/bazel#5640.
Change spawn strategy to
sandboxedto work around this. Not sure why it waslocalto begin with (other than a slight performance improvement).Tested locally to ensure this spawn strategy will work.
Signed-off-by: Teju Nareddy [email protected]