Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[infra] Change language attribute from "cpp" to "c++" in build scripts. #3493

Merged
merged 2 commits into from
Mar 12, 2020
Merged

[infra] Change language attribute from "cpp" to "c++" in build scripts. #3493

merged 2 commits into from
Mar 12, 2020

Conversation

Dor1s
Copy link
Contributor

@Dor1s Dor1s commented Mar 12, 2020

Should've done this in #3477. Good news is that nothing failed, the coverage job was just skipped for pretty much all projects.

@Dor1s
[infra] Change language attribute from "cpp" to "c++" in coverage job…
cc0ba37 
… runner.

Should've done this in #3477. Good news is that nothing failed, the coverage job was just skipped for pretty much all projects.
@TravisBuddy
Copy link

Travis tests have failed

Hey @Dor1s,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 2341c7d0-647b-11ea-b857-47bc0e3c428e

Dor1s
Dor1s commented Mar 12, 2020
View reviewed changes
Copy link
Contributor Author

@Dor1s Dor1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBRing and kicking off coverage jobs while it's still March 12th

@TravisBuddy
Copy link

Travis tests have failed

Hey @Dor1s,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 68328dc0-647b-11ea-b857-47bc0e3c428e

@Dor1s Dor1s changed the title [infra] Change language attribute from "cpp" to "c++" in coverage job runner. [infra] Change language attribute from "cpp" to "c++" in build scripts. Mar 12, 2020
@Dor1s Dor1s merged commit 130710d into master Mar 12, 2020
@Dor1s
Copy link
Contributor Author

Dor1s commented Mar 12, 2020

Reported as #3492

@jonathanmetzman
Copy link
Contributor

LGTM

@jonathanmetzman jonathanmetzman deleted the coverage_cpp branch November 19, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanmetzman jonathanmetzman Awaiting requested review from jonathanmetzman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dor1s @TravisBuddy @jonathanmetzman