-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE][kubernetes] try building Go fuzz targets with the standard gofuzz. #3616
Conversation
…dard gofuzz. related to #3614
Travis tests have failedHey @Dor1s, 1st Build./infra/travis/travis_build.py
TravisBuddy Request Identifier: 9fe7a780-7b84-11ea-92ec-4d91dbb50c9a |
Travis tests have failedHey @Dor1s, 1st Build./infra/travis/travis_build.py
TravisBuddy Request Identifier: d45812b0-7b85-11ea-92ec-4d91dbb50c9a |
Travis tests have failedHey @Dor1s, 1st Build./infra/travis/travis_build.py
TravisBuddy Request Identifier: c1488190-7b86-11ea-92ec-4d91dbb50c9a |
Travis tests have failedHey @Dor1s, 1st Build./infra/travis/travis_build.py
TravisBuddy Request Identifier: 5e98e020-7b87-11ea-92ec-4d91dbb50c9a |
@@ -27,7 +27,8 @@ function compile_fuzzer { | |||
local fuzzer="${pkg}_${function}" | |||
|
|||
# Instrument all Go files relevant to this fuzzer | |||
go-fuzz-build -libfuzzer -func "${function}" -o "${fuzzer}.a" "k8s.io/kubernetes/test/fuzz/${pkg}" | |||
go build -buildmode c-archive -gcflags all=-d=libfuzzer -tags=libfuzzer \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lukasz-milewski @mdempsky when you get a chance, could you please take a look at guide us on the right way to build Go fuzz targets using the standard toolchain -- we want to migrate off github.com/dvyukov/go-fuzz/go-fuzz-build
as it shouldn't be needed anymore //cc @inferno-chromium
this PR is just for testing purposes, once we figure out the right way we'll have a unified command / script in the base-builder image. All current Go projects will be migrated to it and the documentation for new projects will be updated.
Thanks for your help!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#3633 works, but @lukasz-milewski @mdempsky need to confirm if we should do that way or if this should go in an official module.
related to #3614
tracking bug: #2714