Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[infra] Save logs when generating code coverage for Go projects (#2817, #2714). #4683

Merged
merged 1 commit into from
Nov 20, 2020
Merged

[infra] Save logs when generating code coverage for Go projects (#2817, #2714). #4683

merged 1 commit into from
Nov 20, 2020

Conversation

Dor1s
Copy link
Contributor

@Dor1s Dor1s commented Nov 20, 2020

No description provided.

Dor1s
Dor1s commented Nov 20, 2020
View reviewed changes
Copy link
Contributor Author

@Dor1s Dor1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBR and giving another try //cc @catenacyber

@Dor1s Dor1s merged commit e534f4f into master Nov 20, 2020
inferno-chromium
inferno-chromium reviewed Nov 21, 2020
View reviewed changes
Copy link
Collaborator

@inferno-chromium inferno-chromium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@catenacyber
Copy link
Contributor

Looks good to me as well.

Now I can see go-dns coverage report on oss-fuzz.com
But not the other projects yet.
Are they coming ?

I notice golang project failed because of dummy mistake cf #4685

@Dor1s
Copy link
Contributor Author

Dor1s commented Nov 21, 2020

Are they coming ?

Yes, they should appear in a day or two. go-dns and syzkaller I launched manually yesterday for testing purposes.

@catenacyber
Copy link
Contributor

Thanks, will take a look tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inferno-chromium inferno-chromium inferno-chromium left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dor1s @catenacyber @inferno-chromium