Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ubuntu upgrade] Upgrade images to Ubuntu 20.04 #6305

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

jonathanmetzman
Copy link
Contributor

Related: #6180.

@jonathanmetzman jonathanmetzman changed the title [Ubuntu upgrade] Upgrade builder and runner images to 20.04 [Ubuntu upgrade] Upgrade images to Ubuntu 20.04 Aug 26, 2021
Copy link
Collaborator

@inferno-chromium inferno-chromium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we get rid of Dockerfile changes we did in those projects after this stablizes.

@jonathanmetzman
Copy link
Contributor Author

Will we get rid of Dockerfile changes we did in those projects after this stablizes.

I don't think so. Most of them are necessary to build on Ubuntu 20.04,
Why?

@inferno-chromium
Copy link
Collaborator

Will we get rid of Dockerfile changes we did in those projects after this stablizes.

I don't think so. Most of them are necessary to build on Ubuntu 20.04,
Why?

I was confused before with this block (i thought base-builder was old, and 20.04 is something else, but i read the block properly now). looks like base-builder is 20.04 now and 16.04 will be explcit with :xenial, so this is all fine, ignore my comment.

# Using Ubuntu 16.04 because of breakage on Ubuntu 20.04.
# See https://github.com/google/oss-fuzz/issues/6291 for more details.
FROM gcr.io/oss-fuzz-base/base-builder:xenial
# Delete line above and uncomment line below to upgrade to 20.04.
# FROM gcr.io/oss-fuzz-base/base-builder

@jonathanmetzman
Copy link
Contributor Author

Will we get rid of Dockerfile changes we did in those projects after this stablizes.

I don't think so. Most of them are necessary to build on Ubuntu 20.04,
Why?

I was confused before with this block (i thought base-builder was old, and 20.04 is something else, but i read the block properly now). looks like base-builder is 20.04 now and 16.04 will be explcit with :xenial, so this is all fine, ignore my comment.

# Using Ubuntu 16.04 because of breakage on Ubuntu 20.04.
# See https://github.com/google/oss-fuzz/issues/6291 for more details.
FROM gcr.io/oss-fuzz-base/base-builder:xenial
# Delete line above and uncomment line below to upgrade to 20.04.
# FROM gcr.io/oss-fuzz-base/base-builder

I was also confused. I didn't really consider these when I was thinking of the fixes.
These will be upgraded by the maintainers hopefully soon. Eventually we may force them off.

Copy link
Collaborator

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to wait a few more hours before landing as the ClusterFuzz bot updates are still happening. We might also need to revert #6304 for now as that is dependent on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants