Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Update afl++ (#7008)" #7022

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Revert "Update afl++ (#7008)" #7022

merged 1 commit into from
Dec 16, 2021

Conversation

jonathanmetzman
Copy link
Contributor

This reverts commit 95e437c.

@jonathanmetzman jonathanmetzman enabled auto-merge (squash) December 16, 2021 00:00
@DavidKorczynski
Copy link
Collaborator

Fixes #7008

#7021 too

@jonathanmetzman jonathanmetzman merged commit 6bfab63 into master Dec 16, 2021
@jonathanmetzman jonathanmetzman deleted the revert-aflplusplus branch December 16, 2021 00:38
@rlohning
Copy link
Contributor

Still crashes when building Qt: #7017

@DavidKorczynski
Copy link
Collaborator

DavidKorczynski commented Dec 16, 2021 •
edited
Loading

Still crashes when building Qt: #7017

I think the Qt issue is different from the ones reverted by this commit. See my comment below #7022 (comment)

@jonathanmetzman
Copy link
Contributor Author

Damn, I thought this revert would have prevented the bugs from being filed.

@DavidKorczynski
Copy link
Collaborator

DavidKorczynski commented Dec 16, 2021 •
edited
Loading

Damn, I thought this revert would have prevented the bugs from being filed.

FYI I have not received any failed-build emails from the projects I listed in the issue yesterday. I think it's two different bugs - the stack traces look different.

The projects from #7021 are all going well today and the build issue did not persist.

Also, the number of failed builds today is much shorter than yesterday, and also looks to primarily be the usual suspects of failed builds (with a few exceptions such as qt). So I think your patch worked. QT also failed 13th December - all of the other projects only failed 15th December.

MartinPetkov pushed a commit to MartinPetkov/oss-fuzz that referenced this pull request Aug 15, 2022
@jonathanmetzman @MartinPetkov
Revert "Update afl++ (google#7008)" (google#7022)
c007ce5 
This reverts commit 95e437c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inferno-chromium inferno-chromium inferno-chromium approved these changes

@oliverchang oliverchang Awaiting requested review from oliverchang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonathanmetzman @DavidKorczynski @rlohning @inferno-chromium