Build Exiv2 without inih library #9437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinbackhouse
force-pushed
the
inih-library
branch
from
869e6ca
to
6f258c5
Compare
eamonnmcmanus
pushed a commit
to eamonnmcmanus/oss-fuzz
that referenced
this pull request
Mar 15, 2023
This fixes the build failure in Exiv2. We recently added [inih](https://github.com/benhoyt/inih) as a dependency to Exiv2, but we need a newer version of inih that includes the C++ bindings. OSS-Fuzz is still using a docker image based on Ubuntu 20.04 which doesn't include a sufficiently up-to-date version of the `libinih-dev` package. So I've added a build flag to Exiv2 in Exiv2/exiv2#2465 which enables us to build without the inih dependency. The fuzz target doesn't need inih, so it shouldn't make any difference to the fuzzing results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the build failure in Exiv2.
We recently added inih as a dependency to Exiv2, but we need a newer version of inih that includes the C++ bindings. OSS-Fuzz is still using a docker image based on Ubuntu 20.04 which doesn't include a sufficiently up-to-date version of the
libinih-devpackage. So I've added a build flag to Exiv2 in Exiv2/exiv2#2465 which enables us to build without the inih dependency. The fuzz target doesn't need inih, so it shouldn't make any difference to the fuzzing results.