Update the web user interface aesthetically

[tdewolff]

Update the web user interface aesthetically.
The Refine menu is greyed-out for pages besides the Graph.
The description box now opens upon clicking the filename in the top-right.

[codecov-io]

Codecov Report

Merging #263 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
+ Coverage    65.2%   65.23%   +0.03%     
==========================================
  Files          34       34              
  Lines        7174     7212      +38     
==========================================
+ Hits         4678     4705      +27     
- Misses       2102     2113      +11     
  Partials      394      394

Impacted Files	Coverage Δ
internal/report/source.go	80.5% <100%> (-0.28%)	⬇️
internal/driver/webhtml.go	100% <100%> (ø)	⬆️
internal/measurement/measurement.go	33.64% <0%> (-1.86%)	⬇️
internal/report/report.go	30.41% <0%> (-1.09%)	⬇️
internal/driver/commands.go	43.5% <0%> (-1%)	⬇️
internal/binutils/binutils.go	57.44% <0%> (-0.71%)	⬇️
internal/graph/dotgraph.go	91.21% <0%> (+1.21%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ade723...ed72f73. Read the comment docs.

[aalexand]

Some tests keep failing - related to the changes?

[tdewolff]

@aalexand I don't think so, the fails seem to be in other places.

[aalexand]

I tried the updated UI styling checking out your branch, the new style is super super nice! Very slick.

I am looking into what makes the test failing on the master. I think the changes are unrelated too.

@josef-jelinek can you look at this PR from CSS / JS point of view please? The changes look OK to me, but one more LGTM from you would be useful.

[josef-jelinek]

It looks good to me, just the indentation changes could have been in a separate PR, since there are many falsely detected changes now increasing a probability of an issue slipping through.

[aalexand]

Can you rebase the PR onto current master? I expect that to fix the CI.

[tdewolff]

@josef-jelinek I'll keep this in mind next time
@aalexand Tests are fixed now

[aalexand]

One nit comment, please fix, I'll merge then.

[aalexand]

This change is not needed, please revert.

[tdewolff]

I think that was goimports, but it didn't do it on save this time.

[aalexand]

@tdewolff @spiermar Both #188 and #263 are about to land now, and I think there are going to be some merge conflicts for one of you, as an FYI. I think most of those could be avoided if we defer the whitespace updates in #263, but not sure if it's worth it. Thoughts?

[tdewolff]

I can undo the ws changes, they are not important.

[aalexand]

I do like them but I'd undo / split them out for now so that the PRs don't conflict over these things for now.

…

On Mon, Nov 20, 2017 at 4:32 PM, Taco de Wolff ***@***.***> wrote: I can undo the ws changes, they are not important. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#263 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABctwM4-Vgk2DRi95IhTrdH_TcwBwYzgks5s4hodgaJpZM4QieXz> .

-- Alex

[tdewolff]

Nice! Might be best if I make a PR after #188 to refactor and indent all code properly before pursuing other changes.

[aalexand]

@tdewolff Yep, it probably makes sense to wait un poquito.