Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out common percentage formatting code. #265

Merged
merged 1 commit into from
Nov 19, 2017

Conversation

aalexand
Copy link
Collaborator

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 19, 2017

Codecov Report

Merging #265 into master will decrease coverage by 0.15%.
The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
- Coverage    65.2%   65.05%   -0.16%     
==========================================
  Files          34       34              
  Lines        7174     7163      -11     
==========================================
- Hits         4678     4660      -18     
- Misses       2102     2109       +7     
  Partials      394      394
Impacted Files Coverage Δ
internal/measurement/measurement.go 33.64% <0%> (-1.86%) ⬇️
internal/report/source.go 80.77% <100%> (ø) ⬆️
internal/graph/dotgraph.go 91.21% <100%> (+1.21%) ⬆️
internal/report/report.go 30.41% <16.66%> (-1.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ade723...9bd9f16. Read the comment docs.

@aalexand aalexand merged commit 749be1c into google:master Nov 19, 2017
gmarin13 pushed a commit to gmarin13/pprof that referenced this pull request Dec 17, 2020
@aalexand aalexand deleted the aalexand-share-percentage branch January 11, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants