Fix exception when file type contains colon #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #817 +/- ##
==========================================
- Coverage 66.99% 66.97% -0.02%
==========================================
Files 45 45
Lines 9861 9865 +4
==========================================
+ Hits 6606 6607 +1
- Misses 2795 2797 +2
- Partials 460 461 +1 ☔ View full report in Codecov by Sentry. |
aalexand
reviewed
Nov 5, 2023
cuishuang
force-pushed
the
main
branch
7 times, most recently
from
d091f86
to
c732c69
Compare
aalexand
reviewed
Nov 10, 2023
cuishuang
force-pushed
the
main
branch
2 times, most recently
from
fb16e8d
to
df49e73
Compare
|
Is there anything else you need me to do? I'm happy to do it. |
aalexand
reviewed
Nov 21, 2023
|
It has been modified, please review again. Thanks so much! |
aalexand
reviewed
Dec 3, 2023
aalexand
reviewed
Dec 4, 2023
aalexand
reviewed
Dec 4, 2023
Signed-off-by: cui fliter <[email protected]>
aalexand
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #816