Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated pipes dependency #444

Closed
schlomo opened this issue Mar 21, 2023 · 1 comment
Closed

Remove deprecated pipes dependency #444

schlomo opened this issue Mar 21, 2023 · 1 comment

Comments

@schlomo
Copy link

schlomo commented Mar 21, 2023

I get this warning:

.venv/lib/python3.11/site-packages/fire/core.py:59
DeprecationWarning: 'pipes' is deprecated and slated for removal in Python 3.13
    import pipes

Can you please remove pipes? See https://docs.python.org/3/library/pipes.html#:~:text=Deprecated%20since%20version%203.11%2C%20will%20be%20removed%20in%20version%203.13%3A%20The%20pipes%20module%20is%20deprecated%20(see%20PEP%20594%20for%20details).%20Please%20use%20the%20subprocess%20module%20instead. for more infos.

Fire actually only uses the quote() function and according to https://github.com/python/cpython/blob/3.11/Lib/pipes.py#L66 this is imported from shlex so it should be a straight-forward replacement.

@schlomo schlomo changed the title Remove pipes dependency Remove deprecated pipes dependency Mar 21, 2023
BasedDepartment1 pushed a commit to BasedDepartment1/python-fire that referenced this issue Apr 7, 2023
dbieber pushed a commit that referenced this issue Mar 11, 2024
@a-detiste
Copy link

It's fixed

@dbieber dbieber closed this as completed Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants