Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path to requirements.txt #433

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Fix path to requirements.txt #433

merged 1 commit into from
Feb 1, 2023

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Feb 1, 2023

@dbieber dbieber merged commit 910b1f8 into google:master Feb 1, 2023
@hugovk hugovk deleted the fix-ci branch February 1, 2023 20:37
@Borda
Copy link
Contributor

Borda commented Feb 2, 2023

wondering how that the PR #431 went 🟢

@hugovk
Copy link
Contributor Author

hugovk commented Feb 2, 2023

Because it only ran the CLA check:

image

That was because the test workflow only triggered for push events, and for a push from a fork, means it would only run on the fork's CI, not this upstream:

on: [push]

It failed on #428 because it fixes the triggers:

on: [push, pull_request]

So it also runs on upstream for the PR trigger. This is good, so we can see if PRs from forks pass on the CI. This is very important for open source, where people often contribute from forks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants