Google sync #1456
Merged
Google sync #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not really correct for get_alias to do prefix alias lookups for typing, since that's inconsistent with its behavior for non-typing imports. Plus, we had to work around this in _FromTyping. Since only one caller of get_alias needs prefix lookup, I moved it into the calling code. This has no user-visible effect. PiperOrigin-RevId: 541151409
not-supported-yet. This should prevent the crashes due to not being able to find new `typing` and `enum` members. (Other stdlibs are provided by typeshed and have already been updated.) PiperOrigin-RevId: 542900981
The new version of libcst preserves formatting while merging, rather than autoformat the merged signatures. PiperOrigin-RevId: 544676325
Some tests are sensitive to the version of libcst, and we are using an older libcst version in pre-3.10. PiperOrigin-RevId: 544766327
PiperOrigin-RevId: 544782374
3.7 has (finally!) reached end-of-life anyway. Disables failing 3.7 tests to check if the rest pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.