Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.yml “Don't run this on every push ('on' param)” #1737

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,11 @@
# Outstanding TODOs:
# - Auto PyPI upload?
# - Build sdist here too while we're at it?
# - Don't run this on every push ('on' param)

name: Build wheels
on:
push:
branches: [ main ]
# `on: create` "Runs your workflow when someone creates a Git reference (Git branch or tag) in the workflow's repository. Note: An event will not be created when you create more than three tags at once." -- https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#create . See also: https://github.com/actions/runner/issues/1007
create: # The purpose of this line is to run only when we create a release, which is a tag. I'm assuming these are created in github somehow; if that assumption isn't true, we may need to use on: push: tags instead, cf https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#onpushbranchestagsbranches-ignoretags-ignore
pull_request:
branches: [ main ]
workflow_dispatch:
Expand Down