Make merge_pyi not to overwrite existing type annotations. When we assume that the existing type annotations are correct, we should totally not overwrite it as the same thing can be named in different ways depending on how you import it. But it's not a good idea to change the way how the users have written the import already. #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
cl/678640645
branch
from
6a9c94e
to
e296cd9
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
cl/678640645
branch
2 times, most recently
from
d5437c0
to
6153320
Compare
copybara-service
bot
force-pushed
the
cl/678640645
branch
from
6153320
to
f438ac9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make merge_pyi not to overwrite existing type annotations. When we assume that the existing type annotations are correct, we should totally not overwrite it as the same thing can be named in different ways depending on how you import it. But it's not a good idea to change the way how the users have written the import already.
The former change was introduced in #1644, but it seems that respecting the original code best suits what we think this tool should behave.